Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix SN-GAN example doc #13877

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Jan 14, 2019

Description

related to #13847

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@stu1130 stu1130 requested a review from szha as a code owner January 14, 2019 21:35
@stu1130 stu1130 changed the title fix the wrong argument Fix SN-GAN example doc Jan 14, 2019
@stu1130
Copy link
Contributor Author

stu1130 commented Jan 14, 2019

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 14, 2019
@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 078a6c2 into apache:master Jan 15, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* fix the wrong argument

* fix broken link
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* fix the wrong argument

* fix broken link
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants